Skip to content

feat: Drop support for Node 12 - #379

Closed
nickserv wants to merge 14 commits into
nextfrom
nickmccurdy-patch-1
Closed

feat: Drop support for Node 12#379
nickserv wants to merge 14 commits into
nextfrom
nickmccurdy-patch-1

Conversation

@nickserv

@nickserv nickserv commented Jun 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

What: Don't test with node 10, 12, or 15

Why: Node 10, 12, and 15 reached EOL so let's free up some CI resources.

How: Remove 10, 12, and 15 from node test matrix.

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codecov

codecov Bot commented Jun 12, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #379 (d5313cb) into next (719b35b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              next      #379   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          624       630    +6     
  Branches       231       236    +5     
=========================================
+ Hits           624       630    +6
Impacted Files Coverage Δ
src/to-be-visible.js 100.00% <100.00%> (ø)
src/to-have-focus.js 100.00% <100.00%> (ø)
src/utils.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gnapse

gnapse commented Jul 2, 2021

Copy link
Copy Markdown
Member

@nickmccurdy what's pending for us to merge this?

@nickserv

nickserv commented Jul 4, 2021

Copy link
Copy Markdown
Member Author

This should be safe to merge now, as Node 10 and 15 are no longer supported.

@nickserv nickserv changed the title chore: Don't test with node 10 or 15 feat: Drop support for Node 10 Jul 11, 2021
@nickserv

nickserv commented Jul 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Update: I've also updated engines, so this should be published as a breaking change.

@nickserv nickserv added the BREAKING CHANGE This change will require a major version bump label Jul 11, 2021
@IanVS IanVS mentioned this pull request Feb 25, 2022
Merged
4 tasks
@gnapse
gnapse changed the base branch from main to next March 25, 2022 17:17
@IanVS

IanVS commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

@gnapse are you waiting a little longer to also drop node 12 support? That's coming pretty soon (less than a month, 2022-04-30).

kschow and others added 5 commits April 5, 2022 10:53
@kschow @feedmypixel
fix: Support unenclosed inner text for details elements in to be visi…
af18453 
…ble (#396)

* fix: Support unenclosed innerText for details elements in toBeVisible
* docs: Update documentation for toBeVisible with details element examples
* Restructure tests to have a maximum depth of 5 describes
* fix: Support unenclosed innerText for details elements in toBeVisible
* docs: Update documentation for toBeVisible with details element examples
* Restructure tests to have a maximum depth of 5 describes

Co-authored-by: Ben Chidgey <feedmypixel@users.noreply.github.com>
@holblin Jean-Philippe Zolesio
fix: migrate ccs v3 to @adobe/css-tools v4 (#470)
948d90f 
Co-authored-by: Jean-Philippe Zolesio <zolesio@adobe.com>
@nickserv
Merge branch 'main' into nickmccurdy-patch-1
354433a
@nickserv
feat: Drop support for node 12 (fix #366)
694310e
@nickserv
chore: Test with node 18
d5313cb
@nickserv nickserv changed the title feat: Drop support for Node 10 feat: Drop support for Node 12 Aug 31, 2022
@nickserv

nickserv commented Aug 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Node 12 support has ended, so I've also removed it.

Note that this is still based into next, not main. Not sure if we still want that.

@nickserv

nickserv commented Aug 31, 2022

Copy link
Copy Markdown
Member Author

It would be great to merge this soon if possible. Two users have already gotten confused by #473.

@IanVS

IanVS commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

There's also #438 waiting to be released on the next branch, maybe in a beta?

@nickserv

nickserv commented Aug 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

I noticed, that's why I didn't change the base to main. Are we waiting on shipping other breaking changes?

@IanVS

IanVS commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

There is #453 that I can pick back up if there's a chance it will be merged/released. I kind of gave up hope on a breaking release, until now.

@nickserv

nickserv commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@IanVS Let me know if I can help with anything there. I think we might want another breaking change too: #472

@IanVS

IanVS commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

@nickmccurdy I've updated #453 if you'd like to give it a review. Thanks for the nudge.

@IanVS

IanVS commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

I believe this can be closed now, since #511 dropped support for node < 14.

@nickserv nickserv closed this Aug 22, 2023
@nickserv
nickserv deleted the nickmccurdy-patch-1 branch August 22, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnapse gnapse gnapse approved these changes
@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees

No one assigned

Labels

BREAKING CHANGE This change will require a major version bump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nickserv @gnapse @IanVS @MichaelDeBoey @Dennis273 @kschow @holblin